Add some default binding redirects to use on UWP #12
Conversation
|
Hi @bricelam, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| @@ -691,6 +691,8 @@ function GetCsprojArguments($startupProject, $outputFileName) { | |||
| $dataDirectory = Join-Path $startupProjectDir 'App_Data' | |||
| } elseif ($appConfig) { | |||
| $configurationFile = GetProperty $appConfig.Properties FullPath | |||
| } elseif (IsUwpProject $startupProject) { | |||
| $configurationFile = Join-Path $PSScriptRoot 'uap10.0/ef.exe.config' | |||
There was a problem hiding this comment.
Note, these can be overridden by adding your own App.config to the startup project
| </dependentAssembly> | ||
| </assemblyBinding> | ||
| </runtime> | ||
| </configuration> |
There was a problem hiding this comment.
I am guessing this isn't enough to fix the other issues mentioned in dotnet/efcore#5171:
design-time migrations don't fail with a load error, but still fail due to getting the wrong versions of BCL libraries such as DataAnnotations. See dotnet/efcore#5945.
design-time tools are bound to 1.0.0 assembly versions but need to execute against other versions such as 1.0.1. On UWP, NuGet won't add the necessary binding redirects. See dotnet/efcore#6551.
Those seem to be show stoppers.
There was a problem hiding this comment.
This will enable 1.1 to work by default. 1.0 will still need to add overrides, but we may be able to do more there. We can't solve all the unification issues without a new architecture--too much of unification is done by NuGet at restore time now.
Stopgap for dotnet/efcore#5471
@divega @rowanmiller